Skip to content

feat(event-targets): allow multiple security groups to be provided as… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
piradeepk wants to merge 1 commit into from
Closed

feat(event-targets): allow multiple security groups to be provided as… #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,35 @@ export interface EcsTaskProps {
*
* (Only applicable in case the TaskDefinition is configured for AwsVpc networking)
*
* @default A new security group is created
* @default 'A new security group is created'
* @deprecated use securityGroups instead
*/
readonly securityGroup?: ec2.ISecurityGroup;

/**
* Existing security groups to use for the task's ENIs
*
* (Only applicable in case the TaskDefinition is configured for AwsVpc networking)
*
* @default 'A new security group is created'
*/
readonly securityGroups?: ec2.ISecurityGroup[];
}

/**
* Start a task on an ECS cluster
*/
export class EcsTask implements events.IRuleTarget {
/**
* The security group associated to the task.
*
* @deprecated use securityGroups instead.
*/
public readonly securityGroup?: ec2.ISecurityGroup;
/**
* The security groups associated to the task.
*/
public readonly securityGroups?: ec2.ISecurityGroup[];
private readonly cluster: ecs.ICluster;
private readonly taskDefinition: ecs.TaskDefinition;
private readonly taskCount: number;
Expand All @@ -68,8 +87,17 @@ export class EcsTask implements events.IRuleTarget {
this.taskCount = props.taskCount !== undefined ? props.taskCount : 1;

if (this.taskDefinition.networkMode === ecs.NetworkMode.AWS_VPC) {
const securityGroup = props.securityGroup || this.taskDefinition.node.tryFindChild('SecurityGroup') as ec2.ISecurityGroup;
this.securityGroup = securityGroup || new ec2.SecurityGroup(this.taskDefinition, 'SecurityGroup', { vpc: this.props.cluster.vpc });
if (props.securityGroup !== undefined && props.securityGroups !== undefined) {
throw new Error("Only one of SecurityGroup or SecurityGroups can be populated.");
}

if (props.securityGroups !== undefined) {
this.securityGroups = props.securityGroups;
} else {
const securityGroup = props.securityGroup || this.taskDefinition.node.tryFindChild('SecurityGroup') as ec2.ISecurityGroup;
this.securityGroup = securityGroup || new ec2.SecurityGroup(this.taskDefinition, 'SecurityGroup', { vpc: this.props.cluster.vpc });
this.securityGroups = [this.securityGroup];
}
}
}

Expand Down Expand Up @@ -123,7 +151,7 @@ export class EcsTask implements events.IRuleTarget {
awsVpcConfiguration: {
subnets: this.props.cluster.vpc.selectSubnets(subnetSelection).subnetIds,
assignPublicIp,
securityGroups: this.securityGroup && [this.securityGroup.securityGroupId]
securityGroups: this.securityGroups && this.securityGroups.map(securityGroup => securityGroup.securityGroupId)
}
}
}
Expand Down