Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user to trigger build for same version(force build) #66

Open
2 tasks
Tracked by #12
pixincreate opened this issue Oct 20, 2024 · 1 comment
Open
2 tasks
Tracked by #12
Assignees
Labels
enhancement New feature or request

Comments

@pixincreate
Copy link
Owner

pixincreate commented Oct 20, 2024

  • Allow build only if there's a version bump in the modules that are injected
  • Put a check such that the option build has to be triggered only if it is checked
@pixincreate pixincreate self-assigned this Oct 20, 2024
@pixincreate pixincreate added the enhancement New feature or request label Oct 20, 2024
@pixincreate
Copy link
Owner Author

pixincreate commented Oct 20, 2024

support for forcing ota updates to the same version (with flavor) will be added in future. it will be a significant change and will need extensive testing.
again, i feel there exist a genuine use case where updating modules to the latest version for new features and fixes are needed. however, that should not spam users with builds. so there has to be multiple checks added before pushing an ota and should include human interaction is needed is what i feel.

#52 (comment)

we can do something like below:

  • put a new flag in declarations.sh that goes by name something like FORCE_UPDATE and should be turned off by default
  • The user should have an option to change it by putting the same in env.toml
  • If this flag is true, it should then check if the modules have been updated since the last release, if yes, GrapheneOS version number should not matter, a build has to be built

#52 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant