-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Cannot add sidebar form if sidebar is not visible" error while sidebar is showing #9016
Comments
I also experienced this when creating an announcement in the announcements mod this morning |
I saw this error pop up the first time I tried creating a canvas, but I have not been able to replicate in any other subsequent tests. I reached out to @MMirandi to see if I can observe this happening on his machine. |
It seems like no one can reproduce this consistently any more. Taking a look at the code execution paths, it seems like we should emit the error to datadog if this happens, but I didn't see any instances of it in the production environment. I don't see any obvious places to add additional error handling or error logging, so overall I'm inclined to shelve this issue. If this pops up again we can take another look. |
Can you try always throwing the exception and see if it hits Datadog? And if not, see where/why the error is getting swallowed?
I'll spend some cycles today trying to reproduce while working on welcome mods today |
Yes, I did. If the "Cannot add sidebar form if sidebar is not visible" error is forced to be thrown in the same place, it is logged to Datadog. So it seems like there could be some intermittent issue with the messenger, or the logs failed to be emitted. |
Reliable reproduction for me: https://www.loom.com/share/8e0f1e67634741568f87b22da50b0b7d?from_recorder=1&focus_title=1 Useful for reproducing, but might not be something we need to fix because it's a corner case |
Todd and I did a quick troubleshooting session on this.
Given that this error occurs in very edge-case scenarios, and is hard to reproduce consistently we will pause on continuing to troubleshoot this and monitor to see how often this issue occurs. |
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Actual behavior
An error is show, the form is show, but you can't submit the form
It's happening 100% of the time for @MMirandi? I've been seeing it sporadically
Expected behavior
No error is shown, form is shown and you can submit it
Screenshots/Loom
https://pixiebrix.slack.com/archives/C07DJTPAAHG/p1723830246189949
The text was updated successfully, but these errors were encountered: