Skip to content

Vaft broken in Chromium browsers #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
th3m opened this issue Jun 16, 2024 · 8 comments
Closed

Vaft broken in Chromium browsers #262

th3m opened this issue Jun 16, 2024 · 8 comments

Comments

@th3m
Copy link

th3m commented Jun 16, 2024

Latest vaft permalink that fixes the "FrankerFaceZ loading issue" has broken the functionality in Chromium browsers.
Twitch streams don't load at all.

@pixeltris
Copy link
Owner

I can't reproduce. I tested Brave / Chrome. The userscript version is recommended. Ref #200

@th3m
Copy link
Author

th3m commented Jun 17, 2024

@pixeltris This issue closed way too fast imo.

Anyways tested the userscript and it also doesn't work. So something changed with the latest fix definitely.

Also i know that userscript method can give you less issues, but it is always an extra extension we need to use. The minimal the setup the better.

Try also if it works with Ungoogled Chromium https://chromium.woolyss.com/

@stevenya97
Copy link

stevenya97 commented Jun 18, 2024

Hmm I also can't reproduce it. I tried on a fresh profile of Chrome with just uBo, FrankerFaceZ extensions and the vaft script loaded into uBo and filter added. Are you able to provide some extra details? Which streams are you seeing this on? Can you get a screenshot/recording of this happening? What other extensions are you running?

You can try these tips. Under Chrome extensions page, enable Developer Mode in the top right, this should reveal the Update button near the top of the page, click this to force check uBo update. Then toggle off/on uBo. Should force uBo to regrab the script.
image

Afterwards, go to a twitch stream with ads and open the dev console(hit F12 on keyboard). Navigate over to Console and you should be seeing a message(s) Blocking ads. On the video player itself, you should see a banner with the same message in the top left. Try a couple other streams. If you don't, then #200 applies to you which can randomly occur sadly. If so, Userscript is recommended.
image
image

@mjelloDev
Copy link

mjelloDev commented Jun 18, 2024

Having similiar problem after the latest fix of #249

I am using chromium based browser Cromite already tried the usecscript method with tampermonkey but with no success so far (still won't load like using Ublock method)

@th3m
Copy link
Author

th3m commented Jun 18, 2024

Which streams are you seeing this on? Can you get a screenshot/recording of this happening? What other extensions are you running?

Any stream doesn't matter, same result if i use uBlock or the Userscript. No other extensions are running.
Using ungoogled chromium browser. Was working fine before the #249 fix. I have returned to the previous vaft version and everything works fine atm.

When i try to load a stream with the new fix, everything loads up correctly apart from the video itself. (Chat works etc)
Here is a screenshot:
sshot001

After some more testing i found what is breaking the video. It is the V8 optimizer setting, you need to have it enabled for the video to load. Though with the previous vaft version, the video loads fine with the V8 optimizer disabled.

chrome://settings/content/v8

@pixeltris
Copy link
Owner

Sure I can reopen this. I can't reproduce the issue with the optimizer changes. Both work for me.

Are you certain you don't have any other extensions installed and you only have one script enabled? Solutions tend to conflict with each other and produce this exact result (black screen, infinite loading wheel). TTV LOL PRO had some mitigations to allow the stream to load even with a script enabled but with the #249 change that is no longer the case so if you have that extension installed at the same time as the script the streams will now fail to load. See younesaassila/ttv-lol-pro#334

@pixeltris pixeltris reopened this Jun 18, 2024
@DaveKap
Copy link

DaveKap commented Jun 19, 2024

Using Supermium: Had an issue where neither of the uBlock vaft scripts were working but the userscript was working through violentmonkey (which wasn't running anything while I tried the uBlock scripts.) Unsure what's going on there, might be uBlock not loading in the scripts fast enough or being cached or something, just wanted to report my latest.

Edit: The scripts have since started working again.
Edit2: Scripts aren't working again, back to the violentmonkey script which is.

@pxia
Copy link

pxia commented Jun 25, 2024

I had this issue that the stream wasn't loading at all. Disabling TTV LOL PRO plugin seems fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants