Add support for arbitrary bind params

Author: st3v

api_test.go

@@ -453,9 +453,15 @@ var _ = Describe("Service Broker API", func() {
 		}
 
 		Describe("binding", func() {
-			var details *brokerapi.BindDetails
+			var (
+				instanceID string
+				bindingID  string
+				details    *brokerapi.BindDetails
+			)
 
 			BeforeEach(func() {
+				instanceID = uniqueInstanceID()
+				bindingID = uniqueBindingID()
 				details = &brokerapi.BindDetails{
 					AppGUID:   "app_guid",
 					PlanID:    "plan_id",
@@ -465,8 +471,6 @@ var _ = Describe("Service Broker API", func() {
 
 			Context("when the associated instance exists", func() {
 				It("calls Bind on the service broker with the instance and binding ids", func() {
-					instanceID := uniqueInstanceID()
-					bindingID := uniqueBindingID()
 					makeBindingRequest(instanceID, bindingID, details)
 					Expect(fakeServiceBroker.BoundInstanceIDs).To(ContainElement(instanceID))
 					Expect(fakeServiceBroker.BoundBindingIDs).To(ContainElement(bindingID))
@@ -489,6 +493,26 @@ var _ = Describe("Service Broker API", func() {
 						Expect(response.StatusCode).To(Equal(422))
 					})
 				})
+
+				Context("when there are arbitrary params", func() {
+					BeforeEach(func() {
+						details.Parameters = map[string]interface{}{
+							"string": "some-string",
+							"number": 1,
+							"object": struct{ Name string }{"some-name"},
+							"array":  []interface{}{"a", "b", "c"},
+						}
+					})
+
+					It("calls Bind on the service broker with all params", func() {
+						makeBindingRequest(instanceID, bindingID, details)
+						Expect(fakeServiceBroker.BoundBindingDetails.Parameters["string"]).To(Equal("some-string"))
+						Expect(fakeServiceBroker.BoundBindingDetails.Parameters["number"]).To(Equal(1.0))
+						Expect(fakeServiceBroker.BoundBindingDetails.Parameters["array"]).To(Equal([]interface{}{"a", "b", "c"}))
+						actual, _ := fakeServiceBroker.BoundBindingDetails.Parameters["object"].(map[string]interface{})
+						Expect(actual["Name"]).To(Equal("some-name"))
+					})
+				})
 			})
 
 			Context("when the associated instance does not exist", func() {

matchers/marshal_to_json_matcher.go

@@ -32,9 +32,9 @@ func (m *marshalToJSONMatcher) Match(actual interface{}) (success bool, err erro
 }
 
 func (m *marshalToJSONMatcher) FailureMessage(actual interface{}) (message string) {
-    return fmt.Sprintf("expected %s to equal %s", actual, m.expectedJSON)
+	return fmt.Sprintf("expected %s to equal %s", actual, m.expectedJSON)
 }
 
 func (m *marshalToJSONMatcher) NegatedFailureMessage(actual interface{}) (message string) {
-    return fmt.Sprintf("expected %s not to equal %s", actual, m.expectedJSON)
-}
+	return fmt.Sprintf("expected %s not to equal %s", actual, m.expectedJSON)
+}

service_broker.go

@@ -21,9 +21,10 @@ type ServiceDetails struct {
 }
 
 type BindDetails struct {
-	AppGUID   string `json:"app_guid"`
-	PlanID    string `json:"plan_id"`
-	ServiceID string `json:"service_id"`
+	AppGUID    string                 `json:"app_guid"`
+	PlanID     string                 `json:"plan_id"`
+	ServiceID  string                 `json:"service_id"`
+	Parameters map[string]interface{} `json:"parameters"`
 }
 
 var (