Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased bundle size in 1.3 #198

Open
kanwei opened this issue Dec 12, 2024 · 4 comments
Open

Increased bundle size in 1.3 #198

kanwei opened this issue Dec 12, 2024 · 4 comments

Comments

@kanwei
Copy link

kanwei commented Dec 12, 2024

Describe the bug
uix now pulls in expound and cljs/spec and cljs/pprint, doubling our bundle size

Include minimal repro
Any project using 1.3

Expected behavior
Not having these dependencies unless we use the functionality

Additional context
One of the main reasons we switched to UIX was to reduce the bundle size, which it did (130k -> 70k from reagent). However, uix now pulls in a bunch of dependencies, like preo, which pulls in expound, and pprint and spec.alpha. We do not use any of the new prop validations and our bundle size is now bigger than when we were using reagent. Is there a way to make these libraries optional? Otherwise we will have to stay on an older version of uix forever. Thanks!

@kanwei
Copy link
Author

kanwei commented Dec 12, 2024

image

@roman01la
Copy link
Collaborator

I see, I'll take a look. Curious what's the diff in bundle size for you between 1.2 and 1.3?

@kanwei
Copy link
Author

kanwei commented Dec 13, 2024

Went from 1.2: [JS: 317.29 KB] [GZIP: 83.89 KB] to 1.3: [JS: 547.98 KB] [GZIP: 139.2 KB]

@roman01la
Copy link
Collaborator

you can create an empty preo.core ns in the meantime, this will overwrite the library and its deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants