Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide for composer installation #50

Closed
bradjones1 opened this issue Jun 10, 2016 · 5 comments
Closed

Provide for composer installation #50

bradjones1 opened this issue Jun 10, 2016 · 5 comments

Comments

@bradjones1
Copy link
Collaborator

Theoretically we could do this with the composer installer, however this package provides both an auth and enrol plugin. Perhaps we could whip up a quick custom installer?

@pitbulk
Copy link
Owner

pitbulk commented Jun 10, 2016

I think is a good idea to add this functionality.
I keep auth and enroll in the same repo because enroll depends of auth and for me is easier for maintain, but you can see that in Moodle, there are 2 different plugins and each has its own place:

So what is your suggestion?

@bradjones1
Copy link
Collaborator Author

@pitbulk My suggestion would actually be to do a subtree split and have a separate repo for each of these. Partly because it would be easier to have them installable via composer (and one can require the other) but also that it would be easier to integrate with travis for CI, since it's looking for a version.php at the top-level of the repo. Does that sound OK for you?

@pitbulk
Copy link
Owner

pitbulk commented Aug 3, 2016

Ok, I will try to create 2 new repos, update Moodle to reference them and set a note on this repo to reference them too.

But right now I'm quite busy so that will take time.

@bradjones1
Copy link
Collaborator Author

@pitbulk I've created a new moodle-saml organization and added you to it, with repos for the subtree splits. I will seed those, shortly.

@pitbulk
Copy link
Owner

pitbulk commented Aug 3, 2016

Ok, perfect if you can take care of that part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants