Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tempfile.mkstemp for safer temp file creation #106

Merged
merged 3 commits into from
Jan 9, 2021
Merged

Use tempfile.mkstemp for safer temp file creation #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7b83cd
Use tempfile.mkstemp for safer in_temp file creation.
ergoithz Feb 11, 2020
c73e1cc
Merge branch 'master' into master
mpenkov Jan 9, 2021
7795ec1
Update CHANGELOG.md
mpenkov Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Do not create tables when in read-only mode (PR [#128](https://github.com/RaRe-Technologies/sqlitedict/pull/128), [@hholst80](https://github.com/hholst80))
- Use tempfile.mkstemp for safer temp file creation (PR [#106](https://github.com/RaRe-Technologies/sqlitedict/pull/106), [@ergoithz](https://github.com/ergoithz))

## 1.7.0, 04/09/2018

Expand Down
5 changes: 2 additions & 3 deletions sqlitedict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import os
import sys
import tempfile
import random
import logging
import traceback

Expand Down Expand Up @@ -140,8 +139,8 @@ def __init__(self, filename=None, tablename='unnamed', flag='c',
"""
self.in_temp = filename is None
if self.in_temp:
randpart = hex(random.randint(0, 0xffffff))[2:]
filename = os.path.join(tempfile.gettempdir(), 'sqldict' + randpart)
fd, filename = tempfile.mkstemp(prefix='sqldict')
os.close(fd)

if flag not in SqliteDict.VALID_FLAGS:
raise RuntimeError("Unrecognized flag: %s" % flag)
Expand Down