From 8140778254168608e489786c0d3b2235ab2a3713 Mon Sep 17 00:00:00 2001 From: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Date: Tue, 23 Jul 2024 09:05:00 +0900 Subject: [PATCH 1/2] add EphemeralStorage to RegisterTaskDefinition() (#5063) Signed-off-by: t-kikuc Signed-off-by: pipecd-bot --- pkg/app/piped/platformprovider/ecs/client.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/app/piped/platformprovider/ecs/client.go b/pkg/app/piped/platformprovider/ecs/client.go index 178dca1f4b..6598b93af5 100644 --- a/pkg/app/piped/platformprovider/ecs/client.go +++ b/pkg/app/piped/platformprovider/ecs/client.go @@ -176,6 +176,7 @@ func (c *client) RegisterTaskDefinition(ctx context.Context, taskDefinition type NetworkMode: taskDefinition.NetworkMode, Volumes: taskDefinition.Volumes, RuntimePlatform: taskDefinition.RuntimePlatform, + EphemeralStorage: taskDefinition.EphemeralStorage, // Requires defined at task level in case Fargate is used. Cpu: taskDefinition.Cpu, Memory: taskDefinition.Memory, From 4c283fce2f2cbd888337408109ef73c0247b8a33 Mon Sep 17 00:00:00 2001 From: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com> Date: Thu, 25 Jul 2024 17:59:32 +0900 Subject: [PATCH 2/2] Fix type for grpcWeb.Error to grpcweb.RpcError (#5072) Signed-off-by: Yoshiki Fujikane Signed-off-by: pipecd-bot --- web/src/api/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/api/client.ts b/web/src/api/client.ts index 88cfe71a71..d8474b0a87 100644 --- a/web/src/api/client.ts +++ b/web/src/api/client.ts @@ -7,7 +7,7 @@ export const apiClient = new WebServiceClient(apiEndpoint, null, { }); interface ApiCallback { - (err: grpcWeb.Error, response: { toObject: () => Res }): void; + (err: grpcWeb.RpcError, response: { toObject: () => Res }): void; } export async function apiRequest(