From 97b8beca18f0b8235af0c086ee8943cf1350b25e Mon Sep 17 00:00:00 2001 From: t-kikuc Date: Wed, 31 Jan 2024 18:13:20 +0900 Subject: [PATCH 1/2] Add doc NOTE for ECS ELB Listeners Signed-off-by: t-kikuc --- .../managing-application/defining-app-configuration/ecs.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md b/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md index 54fe3ad3d3..afe025510c 100644 --- a/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md +++ b/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md @@ -144,6 +144,11 @@ spec: - name: ECS_CANARY_CLEAN ``` +## NOTE + +- When you use ELB for deployments, all listener rules that have the same target groups as configured in app.pipecd.yaml will be controlled. +- For more information and diagrams, see [Issue#4733 [ECS] Modify ELB listener rules other than defaults without adding config](https://github.com/pipe-cd/pipecd/pull/4733). + ## Reference See [Configuration Reference](../../../configuration-reference/#ecs-application) for the full configuration. From 83add30a71ade4b265bc85a52941cc9621af43eb Mon Sep 17 00:00:00 2001 From: t-kikuc Date: Wed, 31 Jan 2024 18:15:59 +0900 Subject: [PATCH 2/2] Fix typo in doc Signed-off-by: t-kikuc --- .../managing-application/defining-app-configuration/ecs.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md b/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md index afe025510c..523d93837f 100644 --- a/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md +++ b/docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md @@ -146,7 +146,7 @@ spec: ## NOTE -- When you use ELB for deployments, all listener rules that have the same target groups as configured in app.pipecd.yaml will be controlled. +- When you use an ELB for deployments, all listener rules that have the same target groups as configured in app.pipecd.yaml will be controlled. - For more information and diagrams, see [Issue#4733 [ECS] Modify ELB listener rules other than defaults without adding config](https://github.com/pipe-cd/pipecd/pull/4733). ## Reference