Introduce service stable logic to ensure ECS workload available #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4548 +/- ##
==========================================
- Coverage 29.97% 29.95% -0.03%
==========================================
Files 220 220
Lines 25851 25872 +21
==========================================
Hits 7749 7749
- Misses 17455 17476 +21
Partials 647 647
☔ View full report in Codecov by Sentry. |
khanhtc1202
changed the title
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
changed the title
Signed-off-by: khanhtc1202 <[email protected]>
|
@kentakozuka plz |
kentakozuka
reviewed
Aug 22, 2023
Comment on lines
+38
to
+41
| // Retry wait service stable check. | ||
| retryServiceStable = 40 | ||
| // Interval wait service stable check. | ||
| retryServiceStableInterval = 15 * time.Second |
There was a problem hiding this comment.
Can you tell me why this timeout is 10mins(40 * 15sec)?
The default deployment timeout is now 6 hours.
There was a problem hiding this comment.
This follows the AWS cli implementation, where they use the above numbers. Of course, we can wait up to 6 hours, but I just feel like it's overdoing.
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/ecs/wait/services-stable.html#description
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Aug 27, 2023
…-cd#4548) * Introduce service stable logic to ensure ECS workload available Signed-off-by: khanhtc1202 <[email protected]> * Reimplement WaitServiceStable logic Signed-off-by: khanhtc1202 <[email protected]> * Update waiting logic Signed-off-by: khanhtc1202 <[email protected]> * Update service stable condition Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: sZma5a <[email protected]>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
…-cd#4548) * Introduce service stable logic to ensure ECS workload available Signed-off-by: khanhtc1202 <[email protected]> * Reimplement WaitServiceStable logic Signed-off-by: khanhtc1202 <[email protected]> * Update waiting logic Signed-off-by: khanhtc1202 <[email protected]> * Update service stable condition Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: moko-poi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4478
Does this PR introduce a user-facing change?: