From d2ad561805897eb72a7db907e4e92a505281d0d0 Mon Sep 17 00:00:00 2001 From: nghialv Date: Fri, 4 Mar 2022 19:05:34 +0900 Subject: [PATCH 1/3] Add an action to validate generated code --- .../workflows/validate-generated-code.yaml | 28 +++++++++++++++++++ Makefile | 2 +- dockers/codegen/DOCKER_BUILD | 2 +- dockers/codegen/codegen.sh | 8 ++++++ 4 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/validate-generated-code.yaml diff --git a/.github/workflows/validate-generated-code.yaml b/.github/workflows/validate-generated-code.yaml new file mode 100644 index 0000000000..ef8298ed47 --- /dev/null +++ b/.github/workflows/validate-generated-code.yaml @@ -0,0 +1,28 @@ +name: "Validate Generated Code" + +on: + pull_request: + branches: [ master ] + +jobs: + my_first_job: + steps: + - name: My first step + uses: docker://gcr.io/cloud-builders/gradle + +jobs: + analyze: + name: Analyze + steps: + - name: Checkout repository + uses: actions/checkout@v2 + - name: Generate code + uses: docker://gcr.io/pipecd/codegen:0.2.0 + with: + args: /github/workspace + - name: Show Git status + shell: bash + run: git status + - name: Validate + shell: bash + run: test -z "$(git status --porcelain)" diff --git a/Makefile b/Makefile index ec2af140c2..7a7e11445d 100644 --- a/Makefile +++ b/Makefile @@ -133,4 +133,4 @@ update-docsy: .PHONY: codegen codegen: - docker run --rm -v ${PWD}:/repo -it gcr.io/pipecd/codegen:0.1.0 + docker run --rm -v ${PWD}:/repo -it gcr.io/pipecd/codegen:0.2.0 /repo diff --git a/dockers/codegen/DOCKER_BUILD b/dockers/codegen/DOCKER_BUILD index 8f3200edaf..594e9be91d 100644 --- a/dockers/codegen/DOCKER_BUILD +++ b/dockers/codegen/DOCKER_BUILD @@ -1,2 +1,2 @@ -version: 0.1.0 +version: 0.2.0 registry: gcr.io/pipecd/codegen diff --git a/dockers/codegen/codegen.sh b/dockers/codegen/codegen.sh index f74fcbb702..941ca7038f 100755 --- a/dockers/codegen/codegen.sh +++ b/dockers/codegen/codegen.sh @@ -4,6 +4,14 @@ set -o errexit set -o nounset set -o pipefail +while [[ -z "$1" ]] +do + echo "Missing path to the root of repository" + exit 1 +done + +cd $1 + # Generate Go files from proto files. goProtoDirs=( "pkg/model" From 9217de0e16f8633b61fd1eaf624121cd5bd1a648 Mon Sep 17 00:00:00 2001 From: nghialv Date: Fri, 4 Mar 2022 19:18:02 +0900 Subject: [PATCH 2/3] Fix action --- .github/workflows/validate-generated-code.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/validate-generated-code.yaml b/.github/workflows/validate-generated-code.yaml index ef8298ed47..fa33cc40d1 100644 --- a/.github/workflows/validate-generated-code.yaml +++ b/.github/workflows/validate-generated-code.yaml @@ -4,12 +4,6 @@ on: pull_request: branches: [ master ] -jobs: - my_first_job: - steps: - - name: My first step - uses: docker://gcr.io/cloud-builders/gradle - jobs: analyze: name: Analyze From 3e23931145a2ff364a8f868cabde3124fd6a1bb4 Mon Sep 17 00:00:00 2001 From: nghialv Date: Fri, 4 Mar 2022 19:21:25 +0900 Subject: [PATCH 3/3] Fix indent --- .github/workflows/validate-generated-code.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/validate-generated-code.yaml b/.github/workflows/validate-generated-code.yaml index fa33cc40d1..330c1cf78b 100644 --- a/.github/workflows/validate-generated-code.yaml +++ b/.github/workflows/validate-generated-code.yaml @@ -14,7 +14,7 @@ jobs: uses: docker://gcr.io/pipecd/codegen:0.2.0 with: args: /github/workspace - - name: Show Git status + - name: Show Git status shell: bash run: git status - name: Validate