Skip to content

Add project label to piped metrics #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Aug 18, 2021
Merged

Add project label to piped metrics #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pkg/app/piped/cmd/piped/piped.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func (p *piped) run(ctx context.Context, t cli.Telemetry) (runErr error) {
}

// Register all metrics.
registry := registerMetrics(cfg.PipedID)
registry := registerMetrics(cfg.PipedID, cfg.ProjectID)

// Initialize notifier and add piped events.
notifier, err := notifier.NewNotifier(cfg, t.Logger)
Expand Down Expand Up @@ -677,13 +677,17 @@ func (p *piped) getConfigDataFromSecretManager(ctx context.Context) ([]byte, err
return resp.Payload.Data, nil
}

func registerMetrics(pipedID string) *prometheus.Registry {
func registerMetrics(pipedID, projectID string) *prometheus.Registry {
r := prometheus.NewRegistry()
wrapped := prometheus.WrapRegistererWith(map[string]string{
"pipecd_component": "piped",
"piped": pipedID,
"piped_version": version.Get().Version,
}, r)
wrapped := prometheus.WrapRegistererWith(
map[string]string{
"pipecd_component": "piped",
"piped": pipedID,
"piped_version": version.Get().Version,
"project": projectID,
},
r,
)
wrapped.Register(collectors.NewGoCollector())
wrapped.Register(collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}))

Expand Down