From 9934c540af5cb56a297771616edfcaf39cd40bb0 Mon Sep 17 00:00:00 2001 From: khanhtc1202 Date: Fri, 22 Jan 2021 10:39:34 +0900 Subject: [PATCH 1/2] Using aws.StringValue and destructuring map with key value pair --- pkg/app/piped/cloudprovider/lambda/client.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/app/piped/cloudprovider/lambda/client.go b/pkg/app/piped/cloudprovider/lambda/client.go index 81941126f4..2783964c72 100644 --- a/pkg/app/piped/cloudprovider/lambda/client.go +++ b/pkg/app/piped/cloudprovider/lambda/client.go @@ -190,7 +190,7 @@ func (c *client) PublishFunction(ctx context.Context, fm FunctionManifest) (vers } return } - version = *cfg.Version + version = aws.StringValue(cfg.Version) return } @@ -254,24 +254,24 @@ func (c *client) GetTrafficConfig(ctx context.Context, fm FunctionManifest) (rou // In case RoutingConfig is nil, 100 percent of current traffic is handled by FunctionVersion version. if cfg.RoutingConfig == nil { routingTrafficCfg["primary"] = VersionTraffic{ - Version: *cfg.FunctionVersion, + Version: aws.StringValue(cfg.FunctionVersion), Percent: 100, } return } // In case RoutingConfig is provided, FunctionVersion value represents the primary version while // RoutingConfig.AdditionalVersionWeights key represents the secondary version. - var newerVersionTraffic float64 - for version := range cfg.RoutingConfig.AdditionalVersionWeights { - newerVersionTraffic = percentageToPercent(*cfg.RoutingConfig.AdditionalVersionWeights[version]) + var secondaryVersionTraffic float64 + for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights { + secondaryVersionTraffic = percentageToPercent(weight) routingTrafficCfg["secondary"] = VersionTraffic{ Version: version, - Percent: newerVersionTraffic, + Percent: secondaryVersionTraffic, } } routingTrafficCfg["primary"] = VersionTraffic{ - Version: *cfg.FunctionVersion, - Percent: 100 - newerVersionTraffic, + Version: aws.StringValue(cfg.FunctionVersion), + Percent: 100 - secondaryVersionTraffic, } return From fdcf8bfba1ff06bf67ac13e4a865628e970e67ad Mon Sep 17 00:00:00 2001 From: khanhtc1202 Date: Fri, 22 Jan 2021 10:57:31 +0900 Subject: [PATCH 2/2] Using float64Value --- pkg/app/piped/cloudprovider/lambda/client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/app/piped/cloudprovider/lambda/client.go b/pkg/app/piped/cloudprovider/lambda/client.go index 2783964c72..e5a9bff4d3 100644 --- a/pkg/app/piped/cloudprovider/lambda/client.go +++ b/pkg/app/piped/cloudprovider/lambda/client.go @@ -263,7 +263,7 @@ func (c *client) GetTrafficConfig(ctx context.Context, fm FunctionManifest) (rou // RoutingConfig.AdditionalVersionWeights key represents the secondary version. var secondaryVersionTraffic float64 for version, weight := range cfg.RoutingConfig.AdditionalVersionWeights { - secondaryVersionTraffic = percentageToPercent(weight) + secondaryVersionTraffic = percentageToPercent(aws.Float64Value(weight)) routingTrafficCfg["secondary"] = VersionTraffic{ Version: version, Percent: secondaryVersionTraffic,