Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to specify version for templating tools #4382

Closed
khanhtc1202 opened this issue Jun 9, 2023 · 2 comments · Fixed by #4463
Closed

Better way to specify version for templating tools #4382

khanhtc1202 opened this issue Jun 9, 2023 · 2 comments · Fixed by #4463
Assignees
Labels

Comments

@khanhtc1202
Copy link
Member

What would you like to be added:

apiVersion: pipecd.dev/v1beta1
kind: KubernetesApp
spec:
  input:
    namespace: sample
    helmVersion: 3.8.2
    kustomizeVersion: 5.0.3
...

This configuration should install helm version v3.8.2 and kustomize version v5.0.3, both in the piped container environment, but it's not work like that now.

Why is this needed:

Kustomize can be configured to be used with helm via enable-helm & helm-command flags. The PipeCD currently supports kustomizeOptions, which is a map of options for kustomize build command, so basically users can use enable-helm if they want.

The point to note here is that even if they use helm-command to specify helm version they want to use with kustomize build, there is no way to have that version of helm command via PipeCD configuration currently.

@anhpnv
Copy link
Contributor

anhpnv commented Jul 2, 2023

Hi @khanhtc1202 , can you assign me this issue pls 🙌

@khanhtc1202
Copy link
Member Author

Sure, thank you 🙌

@khanhtc1202 khanhtc1202 moved this to In Progress in v0.44.2 Jul 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.44.2 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants