Update deployment configuration reference #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/approve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
pipecd-bot
reviewed
Aug 7, 2020
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
| const ( | ||
| TrafficRoutingMethodPodSelector TrafficRoutingMethod = "podselector" | ||
| TrafficRoutingMethodIstio TrafficRoutingMethod = "istio" | ||
| KubernetesTrafficRoutingMethodPodSelector KubernetesTrafficRoutingMethod = "podselector" |
Collaborator
There was a problem hiding this comment.
exported const KubernetesTrafficRoutingMethodPodSelector should have comment (or a comment on this block) or be unexported
Collaborator
|
Code coverage for golang is
|
Collaborator
|
failed to handle template rule examples Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: