Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jul 31, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.81%. This pull request decreases coverage by -0.15%.

File Function Base Head Diff
pkg/config/deployment_cloudrun.go CloudRunDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/config/deployment_cloudrun.go CloudRunDeploymentSpec.Validate -- 0.00% +0.00%
pkg/config/deployment_cloudrun.go CloudRunTrafficRoutingStageOptions.Percentages -- 0.00% +0.00%
pkg/config/deployment_lambda.go LambdaDeploymentSpec.GetStage -- 0.00% +0.00%
pkg/config/deployment_lambda.go LambdaDeploymentSpec.Validate -- 0.00% +0.00%
pkg/config/deployment_lambda.go LambdaTrafficRoutingStageOptions.Percentages -- 0.00% +0.00%
pkg/config/deployment.go PipelineStage.UnmarshalJSON 59.09% 40.00% -19.09%

@cakecatz
Copy link
Contributor

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by cakecatz.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 43a6119 into master Jul 31, 2020
@pipecd-bot pipecd-bot deleted the config branch July 31, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants