Skip to content

Conversation

@gkuga
Copy link
Contributor

@gkuga gkuga commented Jul 28, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 20.57%. This pull request decreases coverage by -0.16%.

File Function Base Head Diff
pkg/model/project.go ProjectSingleSignOn.GenerateUserInfo -- 0.00% +0.00%
pkg/model/project.go ProjectSingleSignOn_GitHub.GenerateUserInfo -- 0.00% +0.00%
pkg/model/project.go ProjectSingleSignOn_GitHub.decideRole -- 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jul 29, 2020

@gkuga これはコメントしました。

@pipecd-bot pipecd-bot added size/XL and removed size/L labels Jul 31, 2020
Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

@gkuga gkuga force-pushed the github branch 2 times, most recently from 64f24a7 to 5f9bf25 Compare July 31, 2020 02:53
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.14%. This pull request increases coverage by 0.18%.

File Function Base Head Diff
pkg/model/user.go NewUser -- 0.00% +0.00%
pkg/oauth/github/github.go wrapClient -- 0.00% +0.00%
pkg/oauth/github/github.go clientWrapper.getUser -- 0.00% +0.00%
pkg/oauth/github/github.go clientWrapper.getTeams -- 0.00% +0.00%
pkg/oauth/github/github.go NewOAuthClient -- 0.00% +0.00%
pkg/oauth/github/github.go OAuthClient.GetUser -- 80.00% +80.00%
pkg/oauth/github/github.go OAuthClient.decideRole -- 94.12% +94.12%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.14%. This pull request increases coverage by 0.18%.

File Function Base Head Diff
pkg/model/user.go NewUser -- 0.00% +0.00%
pkg/oauth/github/github.go wrapClient -- 0.00% +0.00%
pkg/oauth/github/github.go clientWrapper.getUser -- 0.00% +0.00%
pkg/oauth/github/github.go clientWrapper.getTeams -- 0.00% +0.00%
pkg/oauth/github/github.go NewOAuthClient -- 0.00% +0.00%
pkg/oauth/github/github.go OAuthClient.GetUser -- 80.00% +80.00%
pkg/oauth/github/github.go OAuthClient.decideRole -- 94.12% +94.12%

@pipecd-bot pipecd-bot added size/L and removed size/XL labels Jul 31, 2020
@nghialv
Copy link
Member

nghialv commented Jul 31, 2020

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit dd4eaf5 into master Jul 31, 2020
@pipecd-bot pipecd-bot deleted the github branch July 31, 2020 07:20
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants