Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 29, 2021

What this PR does / why we need it:

This will be required to allow configuring SSH key for remote Git Helm Chart repositories.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.76%. This pull request decreases coverage by -0.21%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.UpdateApplicationConfigurations -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportUnregisteredApplicationConfigurations -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeploymentChain -- 0.00% +0.00%
pkg/app/api/grpcapi/piped_api.go PipedAPI.InChainDeploymentPlannable -- 0.00% +0.00%
pkg/app/piped/apistore/environmentstore/store.go Store.GetByName -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go fileSystem.Open -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go NewReporter -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.Run -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.scanAppConfigs -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.updateRegisteredApps -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.findRegisteredApps -- 83.33% +83.33%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.updateUnregisteredApps -- 0.00% +0.00%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.findUnregisteredApps -- 91.30% +91.30%
pkg/app/piped/appconfigreporter/appconfigreporter.go Reporter.readApplicationInfo -- 73.33% +73.33%
pkg/app/piped/appconfigreporter/appconfigreporter.go makeGitPathKey -- 100.00% +100.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineNameSpace -- 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.shouldStartPlanningDeployment -- 0.00% +0.00%
pkg/app/piped/trigger/deployment_chain.go Trigger.triggerDeploymentChain -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnChainDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnChainDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/config/config.go Kind.ToApplicationKind -- 100.00% +100.00%
pkg/config/deployment.go ChainApplicationMatcher.Validate -- 75.00% +75.00%
pkg/datastore/deploymentchainstore.go NewDeploymentChainStore -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.AddDeploymentChain -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.UpdateDeploymentChain -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainStore.GetDeploymentChain -- 0.00% +0.00%
pkg/model/application.go IsApplicationConfigFile -- 100.00% +100.00%
pkg/model/command.go Command.IsSyncApplicationCmd -- 0.00% +0.00%
pkg/model/command.go Command.IsChainSyncApplicationCmd -- 0.00% +0.00%
pkg/model/deployment.go IsSuccessfullyCompletedDeployment -- 0.00% +0.00%
pkg/model/deployment.go Deployment.IsInChainDeployment -- 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineResourceHealth 0.00% 0.00% +0.00%
pkg/app/piped/planpreview/terraformdiff.go builder.terraformDiff 0.00% 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates 0.00% 0.00% +0.00%
pkg/config/config.go DecodeYAML 72.73% 81.82% +9.09%
pkg/config/config.go Config.GetGenericDeployment 0.00% 28.57% +28.57%
pkg/app/piped/cloudprovider/kubernetes/kubernetes.go provider.init 0.00% 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.syncPlanners 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%
pkg/config/config.go Config.UnmarshalJSON 83.33% 91.67% +8.33%
pkg/app/api/grpcapi/piped_api.go PipedAPI.CreateDeployment 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determineJobHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/state.go determinePersistentVolumeHealth 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/kubernetes/kubernetes.go initSharedGitClient 0.00% -- +-0.00%
pkg/config/deployment.go DeploymentChainNode.Validate 75.00% -- -75.00%

@nakabonne
Copy link
Member

Nice. This will open up the possibility to be more flexible.
/lgtm

@khanhtc1202
Copy link
Member

Way to go 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants