Rename deployment chain configuration struct field #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
reviewed
Nov 19, 2021
pkg/config/deployment.go
Outdated
| // ApplicationMatchers provides list of ChainApplicationMatcher which contain filters to be used | ||
| // to find applications to deploy as chain node. It's required to not empty. | ||
| Nodes []*DeploymentChainNode `json:"applications"` | ||
| ApplicationMatchers []*ChainApplicationMatcher `json:"applications"` |
nghialv
reviewed
Nov 19, 2021
pkg/config/deployment.go
Outdated
| // as a part of the deployment chain. | ||
| type DeploymentChainNode struct { | ||
| type ChainApplicationMatcher struct { | ||
| AppName string `json:"name"` |
nghialv
approved these changes
Nov 19, 2021
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Collaborator
|
Code coverage for golang is
|
This was referenced Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rename as suggestion discussed in #2815 (comment)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: