Skip to content

Fix typo in doc #2811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 4 commits into from
Nov 19, 2021
Merged

Fix typo in doc #2811

pipecd-bot merged 4 commits into from
Nov 19, 2021
+5 −9

Conversation

@ono-max
Copy link
Member

@ono-max ono-max commented Nov 19, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 19, 2021

COVERAGE

Code coverage for golang is 31.99%. This pull request decreases coverage by -0.17%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetDeployment -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/app/piped/trigger/deployment.go reportMostRecentlyTriggeredDeployment -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommandDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommandDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnOutOfSyncDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnOutOfSyncDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommitDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommitDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listOutOfSyncCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommitCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggered -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggerFailed -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/config/deployment.go PostSync.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChain.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChainNode.Validate -- 75.00% +75.00%
pkg/config/deployment.go DeploymentChainTriggerCondition.Validate -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go builder.findTriggerApps 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.Validate 46.15% 56.25% +10.10%
pkg/config/piped.go SecretManagement.UnmarshalJSON 62.50% 56.25% -6.25%
pkg/config/sealed_secret.go SealedSecretSpec.Validate 85.71% 71.43% -14.29%
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.buildSlackMessage 0.00% 0.00% +0.00%
pkg/app/piped/planner/kubernetes/kubernetes.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.Run 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.updateRepoToLatest 0.00% 0.00% +0.00%
pkg/config/piped.go PipedSpec.Validate 58.33% 57.14% -1.19%
pkg/app/piped/deploysource/deploysource.go provider.prepare 0.00% 0.00% +0.00%
pkg/app/piped/sourcedecrypter/decrypter.go DecryptSealedSecrets 77.27% -- -77.27%
pkg/app/piped/trigger/deployment.go Trigger.reportMostRecentlyTriggeredDeployment 0.00% -- +-0.00%
pkg/app/piped/trigger/deployment.go Trigger.getNotification 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go NewDeterminer 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.ShouldTrigger 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.shouldTriggerOnCommit 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go loadDeploymentConfiguration 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommands 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommits 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.syncApplication 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.listApplications 0.00% -- +-0.00%
pkg/config/piped.go PipedSpec.GetSecretManagement 0.00% -- +-0.00%

nakabonne
nakabonne reviewed Nov 19, 2021
View reviewed changes
@ono-max
Copy link
Member Author

ono-max commented Nov 19, 2021

I'll update others, too.

nakabonne
nakabonne reviewed Nov 19, 2021
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 19, 2021

COVERAGE

Code coverage for golang is 31.99%. This pull request decreases coverage by -0.17%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetDeployment -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/app/piped/trigger/deployment.go reportMostRecentlyTriggeredDeployment -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommandDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommandDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnOutOfSyncDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnOutOfSyncDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommitDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommitDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listOutOfSyncCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommitCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggered -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggerFailed -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/config/deployment.go PostSync.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChain.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChainNode.Validate -- 75.00% +75.00%
pkg/config/deployment.go DeploymentChainTriggerCondition.Validate -- 0.00% +0.00%
pkg/config/piped.go PipedSpec.Validate 58.33% 57.14% -1.19%
pkg/app/piped/deploysource/deploysource.go provider.prepare 0.00% 0.00% +0.00%
pkg/app/piped/notifier/slack.go slack.buildSlackMessage 0.00% 0.00% +0.00%
pkg/app/piped/planner/kubernetes/kubernetes.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/planpreview/builder.go builder.findTriggerApps 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%
pkg/config/sealed_secret.go SealedSecretSpec.Validate 85.71% 71.43% -14.29%
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.Run 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.updateRepoToLatest 0.00% 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.Validate 46.15% 56.25% +10.10%
pkg/config/piped.go SecretManagement.UnmarshalJSON 62.50% 56.25% -6.25%
pkg/app/piped/sourcedecrypter/decrypter.go DecryptSealedSecrets 77.27% -- -77.27%
pkg/app/piped/trigger/deployment.go Trigger.reportMostRecentlyTriggeredDeployment 0.00% -- +-0.00%
pkg/app/piped/trigger/deployment.go Trigger.getNotification 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go NewDeterminer 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.ShouldTrigger 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.shouldTriggerOnCommit 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go loadDeploymentConfiguration 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommands 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommits 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.syncApplication 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.listApplications 0.00% -- +-0.00%
pkg/config/piped.go PipedSpec.GetSecretManagement 0.00% -- +-0.00%

@pipecd-bot pipecd-bot added size/S and removed size/XS labels Nov 19, 2021
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 19, 2021

COVERAGE

Code coverage for golang is 31.99%. This pull request decreases coverage by -0.17%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetDeployment -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/app/piped/trigger/deployment.go reportMostRecentlyTriggeredDeployment -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go determiners.Determiner -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommandDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommandDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnOutOfSyncDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnOutOfSyncDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go NewOnCommitDeterminer -- 0.00% +0.00%
pkg/app/piped/trigger/determiner.go OnCommitDeterminer.ShouldTrigger -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkRepoCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommandCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listOutOfSyncCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.listCommitCandidates -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggered -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggerFailed -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go loadDeploymentConfiguration -- 0.00% +0.00%
pkg/config/deployment.go PostSync.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChain.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChainNode.Validate -- 75.00% +75.00%
pkg/config/deployment.go DeploymentChainTriggerCondition.Validate -- 0.00% +0.00%
pkg/app/piped/planner/ecs/ecs.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/planner/kubernetes/kubernetes.go Planner.Plan 0.00% 0.00% +0.00%
pkg/app/piped/trigger/deployment.go Trigger.triggerDeployment 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.Run 0.00% 0.00% +0.00%
pkg/config/piped.go PipedSpec.Validate 58.33% 57.14% -1.19%
pkg/config/piped.go SecretManagement.UnmarshalJSON 62.50% 56.25% -6.25%
pkg/app/piped/deploysource/deploysource.go provider.prepare 0.00% 0.00% +0.00%
pkg/app/piped/planpreview/builder.go builder.findTriggerApps 0.00% 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.updateRepoToLatest 0.00% 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.Validate 46.15% 56.25% +10.10%
pkg/config/sealed_secret.go SealedSecretSpec.Validate 85.71% 71.43% -14.29%
pkg/app/piped/notifier/slack.go slack.buildSlackMessage 0.00% 0.00% +0.00%
pkg/app/piped/sourcedecrypter/decrypter.go DecryptSealedSecrets 77.27% -- -77.27%
pkg/app/piped/trigger/deployment.go Trigger.reportMostRecentlyTriggeredDeployment 0.00% -- +-0.00%
pkg/app/piped/trigger/deployment.go Trigger.getNotification 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go NewDeterminer 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.ShouldTrigger 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go Determiner.shouldTriggerOnCommit 0.00% -- +-0.00%
pkg/app/piped/trigger/determiner.go loadDeploymentConfiguration 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommands 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.checkNewCommits 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.syncApplication 0.00% -- +-0.00%
pkg/app/piped/trigger/trigger.go Trigger.listApplications 0.00% -- +-0.00%
pkg/config/piped.go PipedSpec.GetSecretManagement 0.00% -- +-0.00%

@nakabonne
Copy link
Member

nakabonne commented Nov 19, 2021

Nice
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 19, 2021

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit b498a80 into master Nov 19, 2021
@pipecd-bot pipecd-bot deleted the patch-05 branch November 19, 2021 06:44
This was referenced Dec 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@nghialv nghialv Awaiting requested review from nghialv

1 more reviewer

@nakabonne nakabonne nakabonne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/docs area/site release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ono-max @pipecd-bot @nakabonne