Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@ono-max
Copy link
Member

ono-max commented Nov 18, 2021

Wow, nice idea 👍
/lgtm

@nakabonne
Copy link
Member

Nice. Do we need to address the case of NotificationEventDeploymentRollingBack as well?

@nakabonne
Copy link
Member

nakabonne commented Nov 18, 2021

In either way, it is able to fall into another PR though.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.91%. This pull request increases coverage by 0.03%.

File Function Base Head Diff
pkg/config/deployment.go PostSync.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChain.Validate -- 66.67% +66.67%
pkg/config/deployment.go DeploymentChainNode.Validate -- 75.00% +75.00%
pkg/config/deployment.go DeploymentChainTriggerCondition.Validate -- 0.00% +0.00%
pkg/app/piped/trigger/trigger.go Trigger.notifyDeploymentTriggerFailed 0.00% 0.00% +0.00%
pkg/config/deployment.go GenericDeploymentSpec.Validate 53.85% 56.25% +2.40%

@khanhtc1202
Copy link
Member Author

Nice. Do we need to address the case of NotificationEventDeploymentRollingBack as well?

Not yet, since we do not return that event anywhere. Should make a separated PR for that (include where we will notify that event to slack) cc @ono-max

@nakabonne
Copy link
Member

Alright 👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 06e8cc3 into master Nov 18, 2021
@pipecd-bot pipecd-bot deleted the add-mention-to-for-trigger-failed-event branch November 18, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants