Ensure Piped uses QUICK_SYNC for deployment triggered on OUT_OF_SYNC #2795
Conversation
nghialv
changed the title
|
Code coverage for golang is
|
|
web-test seems to be failed 👁️ |
|
Code coverage for golang is
|
|
Code coverage for javascript is |
|
Thanks. I have just fixed the test. |
|
Nice |
| // Avoid triggering multiple deployments for the same application in the same iteration. | ||
| if _, ok := triggered[app.Id]; ok { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Looks like the trigger which comes first has a higher priority than the one of the same application which comes after. I'm okay with that but since those candidates come from different kinds (onCommand, onCommit, onOutOfSync, etc), maybe we need a better way to choose which one should have a higher priority based on the c.Kind or something.
There was a problem hiding this comment.
Yes. I understand your feeling. 👍
Tbh, I was thinking about that. One way I was planned to use is sorting the candidate list in this function by kind, but after the second thought, I decided to do nothing because the passing list could be controlled by the caller. The caller can sort in the order it wants.
Maybe in the future, when we have more kinds we can add some kind of priority field to the candidate struct to decide.
There was a problem hiding this comment.
Okay, let's keep it as is and make changes to use ordering later.
|
Nice work 👍 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: