Skip to content

Conversation

@ono-max
Copy link
Member

@ono-max ono-max commented Nov 17, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Nov 17, 2021

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.95%. This pull request decreases coverage by -0.02%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.GetDeployment -- 0.00% +0.00%

@pipecd-bot pipecd-bot merged commit ed05b85 into master Nov 17, 2021
@pipecd-bot pipecd-bot deleted the patch-02 branch November 17, 2021 01:07
@ono-max ono-max restored the patch-02 branch November 25, 2021 00:41
@ono-max ono-max deleted the patch-02 branch November 25, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants