Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 9, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2770

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.09%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/terraform.go WithAdditionalEnvs -- 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Apply 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Version 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Init 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.SelectWorkspace 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Plan 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.09%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/terraform.go WithAdditionalEnvs -- 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Version 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Init 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.SelectWorkspace 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Plan 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Apply 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.09%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/terraform/terraform.go WithAdditionalEnvs -- 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Init 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.SelectWorkspace 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Plan 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Apply 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Version 0.00% 0.00% +0.00%

@ono-max
Copy link
Member

ono-max commented Nov 10, 2021

Nice.

/lgtm

@nakabonne
Copy link
Member

I'm sure it will work as well as we'd like 👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 475bd66 into master Nov 10, 2021
@pipecd-bot pipecd-bot deleted the terraform-env branch November 10, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configuring environment variables for Terraform command used while deploying Terraform application

5 participants