Skip to content

Simplify quickstart by getting rid of cloning manifests repository #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 3 commits into from
Nov 5, 2021
Merged

Simplify quickstart by getting rid of cloning manifests repository #2744

pipecd-bot merged 3 commits into from
Nov 5, 2021

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Nov 4, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested a review from ono-max November 4, 2021 10:46
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 4, 2021

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

khanhtc1202 commented Nov 4, 2021

Nice
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Nov 4, 2021
@khanhtc1202
Copy link
Member

khanhtc1202 commented Nov 4, 2021

/lgtm cancel

@pipecd-bot pipecd-bot removed the lgtm label Nov 4, 2021
@khanhtc1202
Copy link
Member

khanhtc1202 commented Nov 4, 2021 •
edited
Loading

could you update /docs-dev and other versions docs (at least v0.21.x) too 🙏 If not, when we release the new version docs, this change will be reverted since the /docs is synced from /docs-dev. Basically, we should avoid change on /docs directly, should use make command to update the /docs content intead.

@nghialv
Copy link
Member Author

nghialv commented Nov 5, 2021

Oops. Let me update them.

@pipecd-bot pipecd-bot added size/L and removed size/M labels Nov 5, 2021
nghialv
nghialv commented Nov 5, 2021
View reviewed changes
docs/content/en/docs-v0.18.x/quickstart/_index.md
helm -n pipecd install pipecd ./manifests/pipecd --dependency-update --create-namespace \
--values ./quickstart/control-plane-values.yaml
helm install pipecd pipecd/pipecd -n pipecd --dependency-update --create-namespace \
--values https://raw.githubusercontent.com/pipe-cd/manifests/{{< blocks/latest_version >}}/quickstart/control-plane-values.yaml
Copy link
Member Author

@nghialv nghialv Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show v0.21.1 but let me fix that problem later.

@nghialv
Copy link
Member Author

nghialv commented Nov 5, 2021

I have just updated the docs. PTAL.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 5, 2021

COVERAGE

Code coverage for golang is 32.11%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

nakabonne commented Nov 5, 2021

Good job
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Nov 5, 2021
@khanhtc1202
Copy link
Member

khanhtc1202 commented Nov 5, 2021

Nice
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Nov 5, 2021

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit a9cf2b4 into master Nov 5, 2021
@pipecd-bot pipecd-bot deleted the quickstart branch November 5, 2021 02:22
This was referenced Dec 1, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@ono-max ono-max Awaiting requested review from ono-max

Assignees

No one assigned

Labels

approved area/docs area/site lgtm release-note-none size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nghialv @pipecd-bot @khanhtc1202 @nakabonne