Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Sep 22, 2021

What this PR does / why we need it:

Because in the case of using GKE Autopilot, they are denied by GKE.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Remove MutatingWebhook/ValidatingWebhook from default watching K8s resources (They can be added explicitly in Piped config).

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.03%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

/lgtm

@ono-max
Copy link
Member

ono-max commented Sep 22, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by ono-max.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 68b4eab into master Sep 22, 2021
@pipecd-bot pipecd-bot deleted the resource branch September 22, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants