Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jul 1, 2021

What this PR does / why we need it:

  • Add ctx to Get function to allow canceling the request
  • Ensure that only one API call is executed for a given environment at a time

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.58%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/piped/apistore/environmentstore/store.go Store.Get 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member

Nice. Your effort helps us.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 9ee766f into master Jul 1, 2021
@pipecd-bot pipecd-bot deleted the environment-store branch July 1, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants