Make pipectl plan-preview command renders the results to stdout and file #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/pipectl/cmd/planpreview/planpreview_test.go--- pkg/app/pipectl/cmd/planpreview/planpreview_test.go.orig
+++ pkg/app/pipectl/cmd/planpreview/planpreview_test.go
@@ -39,12 +39,12 @@
{
name: "there is only a plannable application",
results: []*model.PlanPreviewCommandResult{
- &model.PlanPreviewCommandResult{
+ {
CommandId: "command-2",
PipedId: "piped-2",
PipedUrl: "https://pipecd.dev/piped-2",
Results: []*model.ApplicationPlanPreviewResult{
- &model.ApplicationPlanPreviewResult{
+ {
ApplicationId: "app-1",
ApplicationName: "app-1",
ApplicationUrl: "https://pipecd.dev/app-1",
@@ -67,12 +67,12 @@
{
name: "there is only a failure application",
results: []*model.PlanPreviewCommandResult{
- &model.PlanPreviewCommandResult{
+ {
CommandId: "command-2",
PipedId: "piped-2",
PipedUrl: "https://pipecd.dev/piped-2",
Results: []*model.ApplicationPlanPreviewResult{
- &model.ApplicationPlanPreviewResult{
+ {
ApplicationId: "app-2",
ApplicationName: "app-2",
ApplicationUrl: "https://pipecd.dev/app-2",
@@ -93,7 +93,7 @@
{
name: "there is only a failure piped",
results: []*model.PlanPreviewCommandResult{
- &model.PlanPreviewCommandResult{
+ {
CommandId: "command-1",
PipedId: "piped-1",
PipedUrl: "https://pipecd.dev/piped-1",
@@ -110,18 +110,18 @@
{
name: "all kinds",
results: []*model.PlanPreviewCommandResult{
- &model.PlanPreviewCommandResult{
+ {
CommandId: "command-1",
PipedId: "piped-1",
PipedUrl: "https://pipecd.dev/piped-1",
Error: "failed to clone",
},
- &model.PlanPreviewCommandResult{
+ {
CommandId: "command-2",
PipedId: "piped-2",
PipedUrl: "https://pipecd.dev/piped-2",
Results: []*model.ApplicationPlanPreviewResult{
- &model.ApplicationPlanPreviewResult{
+ {
ApplicationId: "app-1",
ApplicationName: "app-1",
ApplicationUrl: "https://pipecd.dev/app-1",
@@ -130,7 +130,7 @@
SyncStrategy: model.SyncStrategy_QUICK_SYNC,
Changes: []byte("changes-1"),
},
- &model.ApplicationPlanPreviewResult{
+ {
ApplicationId: "app-2",
ApplicationName: "app-2",
ApplicationUrl: "https://pipecd.dev/app-2",
@@ -139,7 +139,7 @@
SyncStrategy: model.SyncStrategy_PIPELINE,
Changes: []byte("changes-2"),
},
- &model.ApplicationPlanPreviewResult{
+ {
ApplicationId: "app-3",
ApplicationName: "app-3",
ApplicationUrl: "https://pipecd.dev/app-3",
@@ -147,7 +147,7 @@
EnvName: "env-3",
Error: "wrong application configuration",
},
- &model.ApplicationPlanPreviewResult{
+ {
ApplicationId: "app-4",
ApplicationName: "app-4",
ApplicationUrl: "https://pipecd.dev/app-4",
@@ -157,7 +157,7 @@
},
},
},
- &model.PlanPreviewCommandResult{
+ {
CommandId: "command-3",
PipedId: "piped-3",
PipedUrl: "https://pipecd.dev/piped-3",
|
pipecd-bot
reviewed
Jun 30, 2021
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
Member
Author
|
/golinter fmt |
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for golang is
|
nakabonne
reviewed
Jun 30, 2021
nakabonne
reviewed
Jun 30, 2021
| // All URL fields inside the result model are empty. | ||
| // So we fill them before sending to the client. | ||
| for _, r := range results { | ||
| r.FillURLs(a.webBaseURL) |
Member
There was a problem hiding this comment.
nit: I thought putting this inside right after the loop is enough (like you did before commit 😄 ). But if you intend to be more clear, it's on you
Member
Author
There was a problem hiding this comment.
I will keep this as it is because there are 2 loops (L480, L512) that are updating this list.
Collaborator
|
The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by You can check the build log from here. |
Collaborator
|
Code coverage for golang is
|
Member
|
excellent! |
Member
|
Way to go 🚀 |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates
pipectlto make itsplan-previewcommand renders the results to both stdout and a given file.This also adds the needed fields to the PlanPreview's models.
Which issue(s) this PR fixes:
Fixes #2109
Does this PR introduce a user-facing change?: