Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jun 29, 2021

What this PR does / why we need it:

This wrong name causes a broken link in the README.md of examples repository.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

Nice catch ⚾
/approve

@khanhtc1202
Copy link
Member

/approve cancel

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jun 29, 2021

please update links to example applications on the docs too 👀
https://github.com/pipe-cd/pipe/blame/master/docs/content/en/docs/examples/_index.md#L47

@nghialv
Copy link
Member Author

nghialv commented Jun 29, 2021

Nice catch!
Thank you. Fixed!

@khanhtc1202
Copy link
Member

Thx 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.56%. This pull request increases coverage by 0.14%.

File Function Base Head Diff
pkg/app/piped/apistore/commandstore/store.go store.ListBuildPlanPreviewCommands -- 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go GetExitCode -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go newBuilder -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go builder.Build -- 0.00% +0.00%
pkg/app/piped/planpreview/builder.go builder.listApplications -- 0.00% +0.00%
pkg/app/piped/planpreview/handler.go WithWorkerNum -- 100.00% +100.00%
pkg/app/piped/planpreview/handler.go WithCommandQueueBufferSize -- 0.00% +0.00%
pkg/app/piped/planpreview/handler.go WithCommandCheckInterval -- 100.00% +100.00%
pkg/app/piped/planpreview/handler.go WithCommandHandleTimeout -- 0.00% +0.00%
pkg/app/piped/planpreview/handler.go WithLogger -- 0.00% +0.00%
pkg/app/piped/planpreview/handler.go NewHandler -- 85.71% +85.71%
pkg/app/piped/planpreview/handler.go Handler.Run -- 94.44% +94.44%
pkg/app/piped/planpreview/handler.go Handler.enqueueNewCommands -- 93.75% +93.75%
pkg/app/piped/planpreview/handler.go Handler.handleCommand -- 43.48% +43.48%
pkg/app/piped/apistore/commandstore/store.go store.sync 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Init 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Plan 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/terraform/terraform.go Terraform.Apply 0.00% 0.00% +0.00%

@pipecd-bot pipecd-bot merged commit c4dc2d4 into master Jun 29, 2021
@pipecd-bot pipecd-bot deleted the examples branch June 29, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants