Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

  • Add release panel to JA docs
  • Update make site command reflect change

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@cakecatz
Copy link
Contributor

/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.60%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jun 29, 2021

/approve

@nakabonne
Copy link
Member

It doesn't work fine on my laptop.

❯ make site
env RELEASE=v0.10.2 hugo server --source=docs
Building sites … ERROR 2021/06/29 11:35:43 [en] REF_NOT_FOUND: Ref "/docs/quickstart/": "/Users/s07726/src/github.com/pipe-cd/pipe/docs/content/en/_index.html:1:1": page not found
Built in 1415 ms
Error: Error building site: logged 1 error(s)
make: *** [site] Error 255

@khanhtc1202 did it go well on your environment?

@nakabonne
Copy link
Member

/approve cancel

@khanhtc1202
Copy link
Member Author

It doesn't work fine on my laptop.

❯ make site
env RELEASE=v0.10.2 hugo server --source=docs
Building sites … ERROR 2021/06/29 11:35:43 [en] REF_NOT_FOUND: Ref "/docs/quickstart/": "/Users/s07726/src/github.com/pipe-cd/pipe/docs/content/en/_index.html:1:1": page not found
Built in 1415 ms
Error: Error building site: logged 1 error(s)
make: *** [site] Error 255

@khanhtc1202 did it go well on your environment?

Sure 👀 The error showed that you don't have docs/quickstart even for en version of the documentation, that's weird 🤔
Could you checkout master and rerun the command 🙏

@nakabonne
Copy link
Member

for sure. It doesn't work even at the master branch.

pipe on ᚠ master [$] took 2m42s
❯ make site
hugo server --source=docs
Building sites … ERROR 2021/06/29 11:41:40 [en] REF_NOT_FOUND: Ref "/docs/quickstart/": "/Users/s07726/src/github.com/pipe-cd/pipe/docs/content/en/_index.html:1:1": page not found

@nakabonne
Copy link
Member

okay, let me approve it as it turns out my own issue
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit cbc1c43 into master Jun 29, 2021
@pipecd-bot pipecd-bot deleted the update-docs branch June 29, 2021 02:43
@khanhtc1202
Copy link
Member Author

okay, let me approve it as it turns out my own issue
/approve

thx 🙏

@nakabonne
Copy link
Member

for sure. It doesn't work even at the master branch.

That was because hugo that I'm using is too old

❯ hugo version
Hugo Static Site Generator v0.68.3/extended darwin/amd64 BuildDate: unknown

Updating did fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants