Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Wrong index for cut command yields unexpected result

+ cut -c9- ../release/RELEASE
+ env 'HUGO_ENV=production' 'RELEASE= v0.10.2' hugo

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.60%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Jun 28, 2021

I prefer to trim the both leading and trailing spaces by another command.
But this is nice as well.
Thank you.

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d9a5529 into master Jun 28, 2021
@pipecd-bot pipecd-bot deleted the fix-cut-index branch June 28, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants