Skip to content

Conversation

@nakabonne
Copy link
Member

What this PR does / why we need it:
I realized using env as a label is more general, so let me do tiny updates.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

You first need to set-up the `pipectl`:

- Install it on your CI system or where you want to run according to [this guide](/docs/user-guide/command-line-tool/#installation).
- And then you grab the API key to which the `READ_WRITE` role is attached according to [this guide](/docs/user-guide/command-line-tool/#authentication).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nakabonne I think you could remove the part And then you here, due to the bullet points pattern 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that's what you mean, thank you!

```

Push a new version `0.2.0` as a data.
Push a new version `0.2.0` as a data when the Helm release is complete.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is completed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.49%. This pull request does not change code coverage.

@nakabonne
Copy link
Member Author

PTAL again.

@khanhtc1202
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot removed the lgtm label Jan 21, 2021
@nghialv
Copy link
Member

nghialv commented Jan 21, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 40ea93b into master Jan 21, 2021
@pipecd-bot pipecd-bot deleted the eventwatcher-docs branch January 21, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants