Skip to content

Using retry instead of waiting for a specific duration of time #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 5 commits into from
Jan 20, 2021
Merged

Using retry instead of waiting for a specific duration of time #1451

pipecd-bot merged 5 commits into from
Jan 20, 2021

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 19, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1449

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 19, 2021

COVERAGE

Code coverage for golang is 33.49%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot added size/S and removed size/M labels Jan 19, 2021
@khanhtc1202 khanhtc1202 changed the title Using retry instead of time sleep Using retry instead of waiting for a specific duration of time Jan 19, 2021
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 19, 2021

COVERAGE

Code coverage for golang is 33.49%. This pull request does not change code coverage.

@khanhtc1202 khanhtc1202 marked this pull request as ready for review January 19, 2021 11:30
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 19, 2021

COVERAGE

Code coverage for golang is 33.49%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 19, 2021

COVERAGE

Code coverage for golang is 33.49%. This pull request does not change code coverage.

nghialv
nghialv reviewed Jan 19, 2021
View reviewed changes
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 19, 2021

COVERAGE

Code coverage for golang is 33.49%. This pull request does not change code coverage.

nghialv
nghialv reviewed Jan 20, 2021
View reviewed changes
pkg/app/piped/cloudprovider/lambda/client.go
// RequestRetryTime represents the number of times calling to AWS resource control.
RequestRetryTime = 3
// RetryIntervalDuration represents duration time between retry.
RetryIntervalDuration = 1 * time.Minute
Copy link
Member

@nghialv nghialv Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving these into the executor/lambda package as private consts?

Copy link
Member Author

@khanhtc1202 khanhtc1202 Jan 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's an attribute attached to the AWS API, I think it would be better if it were placed in the AWS client wrapper package.
On the other hand, I planned to use those constants here too UpdateFunction src ( UpdateFunctionConfig has to wait (retry) several times until UpdateFunctionCode process finished in the AWS server )

Copy link
Member

@nghialv nghialv Jan 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's an attribute attached to the AWS API

I am not sure they belong to AWS API or the CloudProvider callers.

But just a nit. 👍

Copy link
Member Author

@khanhtc1202 khanhtc1202 Jan 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's move it to the callers later if necessary 😄

@nghialv
Copy link
Member

nghialv commented Jan 20, 2021

/lgtm

nakabonne
nakabonne approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 20, 2021

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 1d58b0d into master Jan 20, 2021
@pipecd-bot pipecd-bot deleted the fix-waiting-time branch January 20, 2021 02:19
@pipecd-bot pipecd-bot mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nghialv nghialv nghialv left review comments

+1 more reviewer

@nakabonne nakabonne nakabonne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/piped lgtm release-note-none size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using backoff instead of time sleep waiting for a specific duration of time.

5 participants

@khanhtc1202 @pipecd-bot @nghialv @nakabonne