Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jan 19, 2021

What this PR does / why we need it:

Create piped table row component and use it.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.83%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 86.18%. This pull request increases coverage by 0.02%.

File Base Head Diff
src/constants/ui-text.ts 100.00% 100.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jan 19, 2021

Thank you.
/lgtm

</IconButton>
</TableCell>
</TableRow>
<PipedTableRow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, prefix Piped is redundant to me 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanhtc1202
If there were no Piped, wouldn't it be hard to distinguish it from the TableRow in material-ui?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops, I see 👀 In that case, maybe my suggestion is: rename the component to TableRow and in the calling side

import { TableRow as PipedTableRow } from "./piped-table-row";

but in the second thought, It is quite laborious to do so, so the current implementation is LGTM 👍
I'm going to merge this PR 🏃‍♂️

@khanhtc1202
Copy link
Member

Thank you 🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ee09089 into master Jan 19, 2021
@pipecd-bot pipecd-bot deleted the refactor-piped branch January 19, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants