-
Notifications
You must be signed in to change notification settings - Fork 208
Refactor piped list components #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code coverage for javascript is
|
|
Thank you. |
| </IconButton> | ||
| </TableCell> | ||
| </TableRow> | ||
| <PipedTableRow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, prefix Piped is redundant to me 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanhtc1202
If there were no Piped, wouldn't it be hard to distinguish it from the TableRow in material-ui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops, I see 👀 In that case, maybe my suggestion is: rename the component to TableRow and in the calling side
import { TableRow as PipedTableRow } from "./piped-table-row";but in the second thought, It is quite laborious to do so, so the current implementation is LGTM 👍
I'm going to merge this PR 🏃♂️
|
Thank you 🚀 |
What this PR does / why we need it:
Create piped table row component and use it.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: