Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 15, 2021

What this PR does / why we need it:

The role parameter passed to Create/Update Lambda application is the role set for the deploying lambda function (service role), not for the running agent (user role) to deploy it. So, I think it should be a part of FunctionManifest instead of CloudProviderConfig as the current design.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.83%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/lambda/function.go FunctionManifestSpec.validate 80.00% 71.43% -8.57%
pkg/app/piped/cloudprovider/lambda/client.go client.Apply 0.00% 0.00% +0.00%

@nakabonne
Copy link
Member

/lgtm

@khanhtc1202 khanhtc1202 force-pushed the move-role-to-function-manifest branch from c53cbb2 to 3f959a1 Compare January 15, 2021 11:39
@pipecd-bot pipecd-bot removed the lgtm label Jan 15, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.83%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/lambda/client.go client.Apply 0.00% 0.00% +0.00%
pkg/app/piped/cloudprovider/lambda/function.go FunctionManifestSpec.validate 80.00% 71.43% -8.57%

@nghialv
Copy link
Member

nghialv commented Jan 15, 2021

Nice. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 3a31bfe into master Jan 15, 2021
@pipecd-bot pipecd-bot deleted the move-role-to-function-manifest branch January 15, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants