Skip to content

Conversation

@cakecatz
Copy link
Contributor

What this PR does / why we need it:

Create a component to display application sync status and use it on application list/detail.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.96%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.90%. This pull request decreases coverage by -0.00%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationDeployingStatus 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jan 14, 2021

/lgtm

@khanhtc1202
Copy link
Member


/approve

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.90%. This pull request decreases coverage by -0.00%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationDeployingStatus 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.90%. This pull request decreases coverage by -0.00%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationDeployingStatus 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 86.08%. This pull request increases coverage by 0.12%.

File Base Head Diff
src/components/app-sync-status.tsx -- 100.00% +100.00%
src/components/application-detail.tsx 96.30% 96.23% -0.07%
src/components/application-list-item.tsx 93.33% 93.18% -0.15%
src/components/sync-status-icon.tsx 78.57% 83.33% +4.76%
src/constants/ui-text.ts 100.00% 100.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Jan 14, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2403b6f into master Jan 14, 2021
@pipecd-bot pipecd-bot deleted the sync-status branch January 14, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants