Report StateStatus in all cases except piped process is terminated #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
reviewed
Jan 13, 2021
pkg/app/piped/executor/stopsignal.go
Outdated
| func (s *stopSignal) Terminated() bool { | ||
| value := s.signal.Load() | ||
| return StopSignalType(value) != StopSignalNone | ||
| return StopSignalType(value) != StopSignalTerminate |
Collaborator
|
Code coverage for golang is
|
Member
|
/lgtm |
Member
|
Nice catch! Thank you. |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Collaborator
|
Code coverage for golang is
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1413
Does this PR introduce a user-facing change?: