Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 12, 2021

What this PR does / why we need it:

follow #1401

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.06%. This pull request decreases coverage by -0.07%.

File Function Base Head Diff
pkg/app/api/grpcapi/piped_api.go PipedAPI.ReportApplicationDeployingStatus -- 0.00% +0.00%
pkg/app/piped/controller/controller.go controller.reportApplicationDeployingStatus -- 0.00% +0.00%
pkg/app/piped/cloudprovider/lambda/function.go FunctionManifestSpec.validate 80.00% 66.67% -13.33%

@khanhtc1202 khanhtc1202 marked this pull request as ready for review January 12, 2021 09:28
@nghialv
Copy link
Member

nghialv commented Jan 12, 2021

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit b20262a into master Jan 12, 2021
@pipecd-bot pipecd-bot deleted the update-function-create-input branch January 12, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants