Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jan 12, 2021

What this PR does / why we need it:

  • Extract application table row as a component
  • Add tests

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.73%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.94%. This pull request increases coverage by 1.11%.

File Base Head Diff
src/components/application-list-item.tsx -- 93.33% +93.33%
src/components/application-list.tsx -- 90.38% +90.38%
src/components/delete-application-dialog.tsx -- 85.71% +85.71%
src/components/disable-application-dialog.tsx -- 100.00% +100.00%
src/styles/button.ts -- 100.00% +100.00%
src/api/applications.ts 60.98% 68.29% +7.32%
src/components/sealed-secret-dialog.tsx 75.68% 83.78% +8.11%
src/mocks/handlers.ts 100.00% 100.00% +0.00%
src/mocks/services/application.ts 85.71% 80.00% -5.71%
src/modules/applications.ts 90.20% 94.12% +3.92%
src/modules/sealed-secret.ts 85.71% 100.00% +14.29%

@cakecatz cakecatz changed the title WIP: Refactor application list components Refactor application list components Jan 12, 2021
@nghialv
Copy link
Member

nghialv commented Jan 12, 2021

/lgtm

@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit aef9df5 into master Jan 12, 2021
@pipecd-bot pipecd-bot deleted the refactor-app-table branch January 12, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants