Skip to content

Add missing mandatory parameters for functions created with deployment packages #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 1 commit into from
Jan 12, 2021
Merged

Add missing mandatory parameters for functions created with deployment packages #1401

pipecd-bot merged 1 commit into from
Jan 12, 2021

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 12, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1400

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 12, 2021

COVERAGE

Code coverage for golang is 33.73%. This pull request increases coverage by 0.04%.

File Function Base Head Diff
pkg/config/deployment.go GenericDeploymentSpec.Validate -- 100.00% +100.00%
pkg/app/piped/cloudprovider/lambda/function.go FunctionManifestSpec.validate 80.00% 66.67% -13.33%
pkg/app/piped/controller/scheduler.go scheduler.Run 0.00% 0.00% +0.00%
pkg/config/deployment.go PipelineStage.UnmarshalJSON 44.07% 45.90% +1.83%
pkg/config/deployment_kubernetes.go KubernetesDeploymentSpec.Validate 100.00% 66.67% -33.33%

@nghialv
Copy link
Member

nghialv commented Jan 12, 2021

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 12, 2021

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 9f533e4 into master Jan 12, 2021
@pipecd-bot pipecd-bot deleted the add-mandatory-config-fields branch January 12, 2021 07:16
@khanhtc1202 khanhtc1202 mentioned this pull request Jan 12, 2021
Merged
pipecd-bot pushed a commit that referenced this pull request Jan 12, 2021
@khanhtc1202
Add runtime and handler to FunctionCreateInput (#1407)
b20262a 
**What this PR does / why we need it**:

follow #1401 

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
@pipecd-bot pipecd-bot mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nakabonne nakabonne Awaiting requested review from nakabonne

@nghialv nghialv Awaiting requested review from nghialv

Assignees

No one assigned

Labels

approved area/piped release-note-none size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lambda function created with deployment packages (container images) missing mandatory fields

4 participants

@khanhtc1202 @pipecd-bot @nghialv