Skip to content

Conversation

@cakecatz
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

should we remove "react-router" from our dependencies on package.json
ref: remix-run/react-router#4648 (comment)

@cakecatz cakecatz changed the title Fix importing of react router module WIP: Fix importing of react router module Jan 12, 2021
@cakecatz cakecatz changed the title WIP: Fix importing of react router module Fix importing of react router module Jan 12, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.76%. This pull request decreases coverage by -0.04%.

File Function Base Head Diff
pkg/app/piped/cloudprovider/kubernetes/state.go determinePersistentVolumeHealth 0.00% 0.00% +0.00%

@cakecatz
Copy link
Contributor Author

@khanhtc1202 Exactly, thank you!

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.83%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

Thank you
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d78301d into master Jan 12, 2021
@pipecd-bot pipecd-bot deleted the fix-importing branch January 12, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants