Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Jan 8, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

@nakabonne
Copy link
Member

Seems that this model is used by only Piped and no communication using it exists. LGTM except for my comment 👍

@nakabonne
Copy link
Member

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Jan 8, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.79%. This pull request decreases coverage by -0.02%.

File Function Base Head Diff
pkg/model/notificationevent.go NotificationEvent.Group -- 66.67% +66.67%
pkg/model/notificationevent.go NotificationEventDeploymentTriggered.GetAppName -- 100.00% +100.00%
pkg/model/notificationevent.go NotificationEventDeploymentPlanned.GetAppName -- 0.00% +0.00%
pkg/model/notificationevent.go NotificationEventDeploymentApproved.GetAppName -- 0.00% +0.00%
pkg/model/notificationevent.go NotificationEventDeploymentRollingBack.GetAppName -- 0.00% +0.00%
pkg/model/notificationevent.go NotificationEventDeploymentSucceeded.GetAppName -- 0.00% +0.00%
pkg/model/notificationevent.go NotificationEventDeploymentFailed.GetAppName -- 0.00% +0.00%
pkg/model/notificationevent.go NotificationEventApplicationSynced.GetAppName -- 0.00% +0.00%
pkg/model/notificationevent.go NotificationEventApplicationOutOfSync.GetAppName -- 0.00% +0.00%
pkg/app/piped/logpersister/stagelogpersister.go stageLogPersister.flushFromLastCheckpoint 61.11% 50.00% -11.11%
pkg/model/event.go Event.Group 66.67% -- -66.67%
pkg/model/event.go EventDeploymentTriggered.GetAppName 100.00% -- -100.00%
pkg/model/event.go EventDeploymentPlanned.GetAppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentApproved.GetAppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentRollingBack.GetAppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentSucceeded.GetAppName 0.00% -- +-0.00%
pkg/model/event.go EventDeploymentFailed.GetAppName 0.00% -- +-0.00%
pkg/model/event.go EventApplicationSynced.GetAppName 0.00% -- +-0.00%
pkg/model/event.go EventApplicationOutOfSync.GetAppName 0.00% -- +-0.00%

@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 2553c29 into master Jan 8, 2021
@pipecd-bot pipecd-bot deleted the event branch January 8, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants