Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jan 8, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1360

Does this PR introduce a user-facing change?:

Show all applications by default on the application list

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@cakecatz cakecatz changed the title Show all applications by default on the application list WIP: Show all applications by default on the application list Jan 8, 2021
@cakecatz cakecatz force-pushed the change-default-filter branch from ba0f0fd to 8f64d4b Compare January 8, 2021 08:49
@cakecatz cakecatz changed the title WIP: Show all applications by default on the application list Show all applications by default on the application list Jan 8, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 84.83%. This pull request decreases coverage by -0.17%.

File Base Head Diff
src/api/applications.ts 64.63% 60.98% -3.66%

@nghialv
Copy link
Member

nghialv commented Jan 8, 2021

Looks good. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 7b99276 into master Jan 8, 2021
@pipecd-bot pipecd-bot deleted the change-default-filter branch January 8, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it more clearly to display of enable/disable of application on the web

4 participants