Skip to content

Update disabled application list item's appearance #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 3 commits into from
Jan 8, 2021
Merged

Update disabled application list item's appearance #1377

pipecd-bot merged 3 commits into from
Jan 8, 2021

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Jan 8, 2021 •
edited
Loading

What this PR does / why we need it:

application list

image

application detail

image

Which issue(s) this PR fixes:

Refs #1360

Does this PR introduce a user-facing change?:

Update disabled application list item's appearance

nghialv
nghialv reviewed Jan 8, 2021
View reviewed changes
pkg/app/web/src/components/application-state-view.tsx Outdated
}

const ERROR_MESSAGE = "It was unable to fetch the latest state of application.";
const DISABLED_APPLICATION_MESSAGE = "This application is disabled.";
Copy link
Member

@nghialv nghialv Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This application is currently disabled. You can enable it from the application list page."

Copy link
Contributor Author

@cakecatz cakecatz Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the message.
Thank you!

image

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 8, 2021

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 8, 2021

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 8, 2021

COVERAGE

Code coverage for javascript is 85.00%. This pull request decreases coverage by -0.01%.

File Base Head Diff
src/components/application-detail.tsx 96.23% 96.30% +0.07%
src/components/application-state-view.tsx 82.61% 81.48% -1.13%

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 8, 2021

COVERAGE

Code coverage for golang is 33.81%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 8, 2021

COVERAGE

Code coverage for javascript is 85.00%. This pull request decreases coverage by -0.01%.

File Base Head Diff
src/components/application-detail.tsx 96.23% 96.30% +0.07%
src/components/application-state-view.tsx 82.61% 81.48% -1.13%

@nghialv
Copy link
Member

nghialv commented Jan 8, 2021

Nice. Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Jan 8, 2021

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ad574f9 into master Jan 8, 2021
@pipecd-bot pipecd-bot deleted the application-list branch January 8, 2021 08:30
@pipecd-bot pipecd-bot mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nghialv nghialv nghialv left review comments

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

Assignees

No one assigned

Labels

approved area/web size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cakecatz @pipecd-bot @nghialv