Fix the bug that deployment timeout error was not handled #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
commented
Jan 8, 2021
| } | ||
|
|
||
| // The stage was failed but not caused by the stop signal. | ||
| if result == model.StageStatus_STAGE_FAILURE && sigType == executor.StopSignalNone { |
Member
Author
There was a problem hiding this comment.
The original code was missing the handling of the timeout error.
khanhtc1202
reviewed
Jan 8, 2021
khanhtc1202
reviewed
Jan 8, 2021
| if !ok { | ||
| s.doneDeploymentStatus = model.DeploymentStatus_DEPLOYMENT_FAILURE | ||
| statusReason = fmt.Sprintf("Unable to find %q from the repository list in piped config", repoID) | ||
| statusReason = fmt.Sprintf("Repository %q is not found in the piped config", repoID) |
Member
There was a problem hiding this comment.
nit, statusDesc or statusDescription or deploymentResultDescription(Desc) can be considered as a better name 🤔
Member
Author
There was a problem hiding this comment.
That name was already fixed/used in the proto so let me keep it as is.
Collaborator
|
Code coverage for golang is
|
khanhtc1202
reviewed
Jan 8, 2021
|
|
||
| var ( | ||
| defaultDeploymentTimeout = time.Hour | ||
| defaultDeploymentTimeout = 6 * time.Hour |
Member
There was a problem hiding this comment.
nit, do we have docs that related to this default value 👀
Member
|
/lgtm |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: