Lambda deployment executor #1365
Conversation
|
Code coverage for golang is
|
| } | ||
|
|
||
| func (e *deployExecutor) ensurePromote(_ context.Context) model.StageStatus { | ||
| return model.StageStatus_STAGE_FAILURE |
There was a problem hiding this comment.
Would it mean to be not supported yet but planned in the future? If so, it would be nice to have a clear comment and emit log like e.LogPersister.Error("This stage is not implemented yet")`
There was a problem hiding this comment.
You're right, let's me add that log 👍
| e.deploySource = ds | ||
| e.deployCfg = ds.DeploymentConfig.LambdaDeploymentSpec | ||
| if e.deployCfg == nil { | ||
| e.LogPersister.Errorf("Malformed deployment configuration: missiong LambdaDeploymentSpec") |
|
/lgtm |
|
Looks not to addressed our comment, but my browser's fault? |
|
Just to confirm. I don't mean to hurry you. |
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
sorry, not yet commit the change 🙏 |
|
No. I lgtm-ed because our comments just are nits. So you can /approve this PR once he fixed them. |
|
@nghialv I got it 👍 |
|
btw, is it just me but even after I commit and push the changes, refresh github page not mark |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: