Skip to content

Conversation

@cakecatz
Copy link
Contributor

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #1274

Does this PR introduce a user-facing change?:

Add an option to do base64 encoding before encrypting the secret

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.25%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.32%. This pull request increases coverage by 0.10%.

File Base Head Diff
src/components/sealed-secret-dialog.tsx 70.59% 75.68% +5.09%
src/constants/ui-text.ts 100.00% 100.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Dec 21, 2020

/lgtm

@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 7a45feb into master Dec 21, 2020
@pipecd-bot pipecd-bot deleted the base64-option branch December 21, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web - Add an option to do base64 encoding before encrypting the secret

5 participants