Fix to ensure ECR region is populated #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code coverage for golang is |
khanhtc1202
reviewed
Dec 18, 2020
| // - AWS_SECRET_ACCESS_KEY or AWS_SECRET_KEY | ||
| func NewECR(name string, region string, opts ...Option) (*ECR, error) { | ||
| if region != "" { | ||
| if region == "" { |
Member
|
/lgtm |
nghialv
approved these changes
Dec 18, 2020
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This has eaten my 1h...
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: