Skip to content

Conversation

@cakecatz
Copy link
Contributor

@cakecatz cakecatz commented Dec 18, 2020

What this PR does / why we need it:

image

Which issue(s) this PR fixes:

Fixes #1159

Does this PR introduce a user-facing change?:

Add sync options to the SYNC button at the application detail

expect(screen.getByText("Healthy")).toBeInTheDocument();
expect(screen.getByText("Synced")).toBeInTheDocument();
expect(screen.getByRole("button", { name: /sync/i })).toBeInTheDocument();
expect(screen.getByRole("button", { name: /sync$/i })).toBeInTheDocument();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this typo? Not sure. ww

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.25%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 83.23%. This pull request increases coverage by 0.10%.

File Base Head Diff
src/components/application-detail.tsx 95.92% 96.23% +0.31%
src/modules/applications.ts 90.00% 89.80% -0.20%
src/modules/commands.ts 90.00% 93.33% +3.33%
src/modules/deployments.ts 77.78% 78.08% +0.30%

@nghialv
Copy link
Member

nghialv commented Dec 18, 2020

/lgtm

@khanhtc1202
Copy link
Member

🚀
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 894b7b5 into master Dec 18, 2020
@pipecd-bot pipecd-bot deleted the force-sync branch December 18, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add force sync option to sync button on the application detail page

5 participants